fix broken tests #135
Merged
fix broken tests #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(because of phpunit-util changes)
|
I hope I catched all places. |
|
@prolic Apparently not. Still failing. |
(because of phpunit-util changes)
|
Okay, that should do it. Feel free to merge @enumag, the other pull requests just need to be rebased after that, so tests pass there as well. |
enumag
reviewed
May 2, 2020
| { | ||
| $this->connection->close(); | ||
|
|
||
| yield new Success(); |
There was a problem hiding this comment.
Because otherwise it's not a generator. tearDown (non-async) is called later, so the test would hang otherwise forever (unless you get to unreference watchers).
There was a problem hiding this comment.
If unreferencing the connection works, then the method can be deleted here anyway, as we don't need to close the connection anymore.
|
Tests pass, yeah! Good night! |
enumag
approved these changes
May 2, 2020
|
Works like a charm. Thanks and good night! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(because of phpunit-util changes)