Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check event appeared callback returns a promise #4

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Conversation

prolic
Copy link
Member

@prolic prolic commented Aug 1, 2018

resolves #3

ping @jvdlaar

@prolic prolic added the enhancement New feature or request label Aug 1, 2018
@jvdlaar
Copy link

jvdlaar commented Aug 1, 2018

Yes this throws an error for me when I reverted my corrupted code!

@prolic prolic merged commit 3d70696 into master Aug 1, 2018
@prolic prolic deleted the eventappeared branch August 1, 2018 15:52
@prolic
Copy link
Member Author

prolic commented Aug 1, 2018

thanks for confirming @jvdlaar - merged into master now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Throw error when callback doesn't return a promise
2 participants