Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to use new async interfaces #81

Merged
merged 2 commits into from Jan 26, 2019
Merged

refactor to use new async interfaces #81

merged 2 commits into from Jan 26, 2019

Conversation

prolic
Copy link
Member

@prolic prolic commented Jan 25, 2019

@prolic prolic added the enhancement New feature or request label Jan 25, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 414

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 67.018%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Internal/EventStoreNodeConnection.php 0 1 0.0%
Totals Coverage Status
Change from base Build 412: 0.04%
Covered Lines: 3558
Relevant Lines: 5309

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 414

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 67.018%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Internal/EventStoreNodeConnection.php 0 1 0.0%
Totals Coverage Status
Change from base Build 412: 0.04%
Covered Lines: 3558
Relevant Lines: 5309

💛 - Coveralls

composer.json Outdated
@@ -27,7 +27,8 @@
"amphp/byte-stream": "^1.5.1",
"amphp/file": "^0.3.3",
"amphp/socket": "^0.10.11",
"prooph/event-store": "dev-master",
"prooph/event-store": "dev-async",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch back to dev-master, once prooph/event-store#358 is merged

@prolic prolic merged commit 62b2c8a into master Jan 26, 2019
@prolic prolic deleted the async branch January 26, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants