Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR-17 ResponseFactory draft instead of ResponsePrototype #5

Merged
merged 1 commit into from Apr 7, 2018

Conversation

codeliner
Copy link
Member

Closes #3

See #4 for discussion

@codeliner codeliner requested a review from prolic April 6, 2018 20:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 27

  • 81 of 81 (100.0%) changed or added relevant lines in 36 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 22: 0.0%
Covered Lines: 472
Relevant Lines: 472

💛 - Coveralls

Copy link
Member

@prolic prolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but where is the JsonTransformer class?

@codeliner
Copy link
Member Author

@prolic JsonTransformer is not part of this package.
It needs to be injected: https://github.com/prooph/event-store-http-middleware/pull/5/files#diff-9782dc5d06a5247229375e61a092313eR28
by implementing the Transformer interface. I'll add an example implementation (which uses Diactoros JsonResponse) to the docs, so users can copy & paste it, but it is userland implementation.

@prolic
Copy link
Member

prolic commented Apr 7, 2018 via email

@prolic
Copy link
Member

prolic commented Apr 7, 2018

I'm going to merge this for now, but please let's implement the json-transformer in a separate PR. We don't need a distinct JsonResponse implementation, the default provided by response factory is good enough.

@prolic prolic merged commit 46479e4 into master Apr 7, 2018
@prolic prolic deleted the response_factory_take_two branch April 7, 2018 20:10
@codeliner codeliner mentioned this pull request Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants