New factory which correctly wraps the event store. #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now added a default EventStoreFactory and a default ActionEventEmitterFactory.
Event Store
As discussed, imho we should not abstract too much in the symfony implementation. Building some wrapper around the event store creation feels cumbersome and is imho unneded. A user just have to configure his own event store.
this service will be used in the store configuration under the "event_store" key (before: type)
The
DefaultEventStoreFactory
now wraps (if configured) the configured EventStore in an (Transactional)ActionEventEmitter.The
DefaultActionEventEmitterFactory
wraps eitherActionEventEmitterEventStore
orTransactionalEventEmitterEventStore
, depending ifTransactionalEventStore
is implemented by theEventStore
ActionEventEmitter
The
event_emitter
config key now only accepts and validates a string of the classname (FQCN) which implements theActionEventEmitter
interface.So now it's possible to build an own
ActionEventEmitterFactory
with a customActionEventEmitter
implementationSome ideas: