repository_class configuration option could be replaced with FQCN repository name #32
Conversation
| $repositoryClass = $repositoryConfig['repository_class'] ?? $repositoryName; | ||
|
|
||
| if (! class_exists($repositoryClass)) { | ||
| throw new RuntimeException(\sprintf( |
There was a problem hiding this comment.
Please remove the leading \ for consistency
|
Docs are already available in #27 |
|
done, thanks for taking care of docs. |
| @@ -176,7 +176,7 @@ private function loadEventStore(string $name, array $options, ContainerBuilder $ | |||
| $repositoryClass = $repositoryConfig['repository_class'] ?? $repositoryName; | |||
|
|
|||
| if (! class_exists($repositoryClass)) { | |||
| throw new RuntimeException(\sprintf( | |||
| throw new RuntimeException(sprintf( | |||
There was a problem hiding this comment.
Why was the \ backslash removed from sprintf? This gives a minimal performance gain.
There was a problem hiding this comment.
I've read somewhere, that the performance difference will be gone in future php version and you shouldn't use this except when needed (but I can't find the sources for this again at the moment). Currently we don't do this within all the prooph components, so even if my statement above would be invalid, let's keep it consistent.
There was a problem hiding this comment.
and tools like cs-fixer can always change it in entire project
|
Thank you @kejwmen |
Implements #5.