AggregateRepository::aggregateType attribute not initialized in the constructor

[dottorbabba]

Hi, I'm constructing my instance of AggregateRepository in this way:

class EventSourcingProjectService extends AggregateRepository implements ProjectService
{
    public function __construct(EventStore $eventStore, StreamStrategyInterface $eventStoreStrategy) {
        parent::__construct($eventStore, new AggregateTranslator(), $eventStoreStrategy, new AggregateType('Ora\ProjectManagement\Project'));
    }

    public function findProject($id)
    {
        $project = $this->getAggregateRoot($this->aggregateType, $id);
        return $project;
    }
} 

but when I call findProject, I got the following error:

Argument 1 passed to Prooph\EventStore\Aggregate\AggregateRepository::getAggregateRoot() must be an instance of Prooph\EventStore\Aggregate\AggregateType, null given"

Looking at the source code, the constructor of AggregateRepository does not initialize aggregateType attribute with the value passed to. Is it correct?

Thank you very much
Andrea

[codeliner]

This is definitely a bug. The way you want to use it is correct.

I always do it this way:

class EventSourcingProjectService extends AggregateRepository implements ProjectService
{
    public function __construct(EventStore $eventStore, StreamStrategyInterface $eventStoreStrategy) {
        $this->aggregateType = new AggregateType('Ora\ProjectManagement\Project');
        parent::__construct($eventStore, new AggregateTranslator(), $eventStoreStrategy);
    }

    public function findProject($id)
    {
        $project = $this->getAggregateRoot($this->aggregateType, $id);
        return $project;
    }
} 

So I have not recognized the bug. I will fix this immediatly and release a new version. Thanks for pointing it out.

[codeliner]

Ok, release is available. v1.1.1 should solve the problem. The fix was already available on master. I fixed it last weekend but have forgotten to draft a new release. To much parallel work at the moment :-)