Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide helper trait for adapters to centralize message conversion logic #56

Closed
3 tasks done
codeliner opened this issue Aug 14, 2015 · 2 comments
Closed
3 tasks done

Provide helper trait for adapters to centralize message conversion logic #56

codeliner opened this issue Aug 14, 2015 · 2 comments
Labels
enhancement
Milestone
5.0 Release

Comments

@codeliner
Copy link
Member

  • Let the trait handle the new adapter options message_factory and message_converter
  • Provide trait methods: messageToArray, messageFromArray
  • May also centralize the payload serializer handling but keep in mind that the mongo db adapter does not need it, so it should be optional
@codeliner codeliner added this to the 5.0 Release milestone Aug 14, 2015
@codeliner codeliner mentioned this issue Aug 14, 2015
Merged
@codeliner
Copy link
Member Author

Done with #59 but maybe it will be removed again depending on the decision of #60

@codeliner codeliner mentioned this issue Aug 18, 2015
Closed
3 tasks
@codeliner
Copy link
Member Author

Decision is made. Helper trait will be removed, see #64 but we will retain the new PayloadSerializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.0 Release
Development

No branches or pull requests
1 participant
@codeliner