Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation #1

Merged
merged 8 commits into from
Jun 12, 2016
Merged

initial implementation #1

merged 8 commits into from
Jun 12, 2016

Conversation

prolic
Copy link
Member

@prolic prolic commented Jun 8, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6668bf8 on initial_implementation into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 30927aa on initial_implementation into * on master*.

@prolic
Copy link
Member Author

prolic commented Jun 11, 2016

@codeliner ready for review, let's add some minimal docs and publish 1.0.0-BETA.1

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1a904e9 on initial_implementation into * on master*.

@prolic prolic changed the title [WIP] initial implementation initial implementation Jun 11, 2016
try {
$command = $this->messageFactory->createMessageFromArray($envelope->getType(), $data);
$this->commandBus->dispatch($command);
} catch (\Exception $e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catch (\Throwable $e) //to catch also new PHP7 errors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great hint, I need to do the same in HumusAmqp, simply forgot about this new feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added issue here: prolic/HumusAmqp#13

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ede777e on initial_implementation into * on master*.

@prolic
Copy link
Member Author

prolic commented Jun 12, 2016

@codeliner updated

@codeliner codeliner merged commit 27c0e25 into master Jun 12, 2016
@codeliner codeliner deleted the initial_implementation branch June 12, 2016 09:32
@codeliner
Copy link
Member

Merged. great job. cool that we have amqp support now.

fyi: I'm off for the rest of the day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants