-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation #1
Conversation
a747aa9
to
0cc94a9
Compare
Changes Unknown when pulling 6668bf8 on initial_implementation into * on master*. |
Changes Unknown when pulling 30927aa on initial_implementation into * on master*. |
@codeliner ready for review, let's add some minimal docs and publish 1.0.0-BETA.1 |
Changes Unknown when pulling 1a904e9 on initial_implementation into * on master*. |
try { | ||
$command = $this->messageFactory->createMessageFromArray($envelope->getType(), $data); | ||
$this->commandBus->dispatch($command); | ||
} catch (\Exception $e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catch (\Throwable $e) //to catch also new PHP7 errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great hint, I need to do the same in HumusAmqp, simply forgot about this new feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added issue here: prolic/HumusAmqp#13
Changes Unknown when pulling ede777e on initial_implementation into * on master*. |
@codeliner updated |
Merged. great job. cool that we have amqp support now. fyi: I'm off for the rest of the day. |
No description provided.