make snapshot store factory optional

prooph · Jan 22, 2017 · 05daa45 · 05daa45
1 parent bd7b7c8
commit 05daa45
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 16 deletions.
diff --git a/examples/register_and_change_username.php b/examples/register_and_change_username.php
@@ -45,17 +45,18 @@
 ];
 
 $dispatch = Kernel\buildCommandDispatcher(
-    $factories['eventStore'],
-    $factories['snapshotStore'],
     $commandMap,
-    $factories['dummyProducer']
+    $factories['eventStore'],
+    $factories['dummyProducer'],
+    $factories['snapshotStore']
 );
 
 // uncomment to enable amqp publisher
 //$dispatch = Kernel\buildCommandDispatcher(
-//    $factories['eventStore'],
 //    $commandMap,
+//    $factories['eventStore'],
 //    $factories['amqpProducer'],
+//    $factories['snapshotStore'],
 //    $factories['startAmqpTransaction'],
 //    $factories['commitAmqpTransaction']
 //);

diff --git a/src/Kernel.php b/src/Kernel.php
@@ -30,7 +30,7 @@
  * builds a dispatcher to return a function that receives a messages and return the state
  *
  * usage:
- * $dispatch = buildDispatcher($eventStoreFactory, $snapshotStoreFactory, $commandMap, $producerFactory);
+ * $dispatch = buildDispatcher($commandMap, $eventStoreFactory, $producerFactory, $snapshotStoreFactory);
  * $state = $dispatch($message);
  *
  * $producerFactory is expected to be a callback that returns an instance of Prooph\ServiceBus\Async\MessageProducer.
@@ -50,17 +50,17 @@
  * $message is expected to be an instance of Prooph\Common\Messaging\Message
  */
 function buildCommandDispatcher(
-    callable $eventStoreFactory,
-    callable $snapshotStoreFactory,
     array $commandMap,
+    callable $eventStoreFactory,
     callable $producerFactory,
+    callable $snapshotStoreFactory = null,
     callable $startProducerTransaction = null,
     callable $commitProducerTransaction = null
 ): callable {
     return function (Message $message) use (
+        $commandMap,
         $eventStoreFactory,
         $snapshotStoreFactory,
-        $commandMap,
         $producerFactory,
         $startProducerTransaction,
         $commitProducerTransaction
@@ -70,6 +70,10 @@ function buildCommandDispatcher(
         };
 
         $loadState = function (AggregateDefiniton $definiton) use ($message, $snapshotStoreFactory): array {
+            if (null === $snapshotStoreFactory) {
+                return [];
+            }
+
             return loadState($snapshotStoreFactory(), $message, $definiton);
         };
 

diff --git a/tests/KernelTest.php b/tests/KernelTest.php
@@ -73,10 +73,10 @@ public function it_builds_command_dispatcher_and_dispatches(): void
         };
 
         $dispatch = \Prooph\Micro\Kernel\buildCommandDispatcher(
-            $eventStoreFactory,
-            $snapshotStoreFactory,
             $commandMap,
-            $producerFactory
+            $eventStoreFactory,
+            $producerFactory,
+            $snapshotStoreFactory
         );
 
         $command = $this->prophesize(Message::class);
@@ -141,10 +141,10 @@ public function it_builds_command_dispatcher_and_dispatches_with_transactional_p
         };
 
         $dispatch = \Prooph\Micro\Kernel\buildCommandDispatcher(
-            $eventStoreFactory,
-            $snapshotStoreFactory,
             $commandMap,
+            $eventStoreFactory,
             $producerFactory,
+            $snapshotStoreFactory,
             $start,
             $commit
         );
@@ -202,10 +202,10 @@ public function it_builds_command_dispatcher_and_dispatches_but_breaks_when_hand
         };
 
         $dispatch = \Prooph\Micro\Kernel\buildCommandDispatcher(
-            $eventStoreFactory,
-            $snapshotStoreFactory,
             $commandMap,
-            $producerFactory
+            $eventStoreFactory,
+            $producerFactory,
+            $snapshotStoreFactory
         );
 
         $command = $this->prophesize(Message::class);