-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improves SetupCommand #18
Conversation
$config .= " - $httpPort:80\n"; | ||
$config = [ | ||
'version' => '2', | ||
'services' => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it was already discussed, but we should use version 3 (requires Docker 1.13 and Docker Composer 1.10) but then we can deploy the stuff to a Swarm Cluster with docker stack deploy --compose-file=docker-compose.yml my_stack
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for version 3. But not available for docker for Mac currently.
thx!!! |
This PR