Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetupCommand improvements #19

Merged
merged 5 commits into from
Jan 24, 2017
Merged

SetupCommand improvements #19

merged 5 commits into from
Jan 24, 2017

Conversation

oqq
Copy link
Member

@oqq oqq commented Jan 24, 2017

This PR changes how the nginx config would be generated by using a helper service and adds some more unit tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.8%) to 24.555% when pulling 3a86f6d on oqq:commands into 57c9db5 on prooph:commands.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 24.459% when pulling da6b96f on oqq:commands into 57c9db5 on prooph:commands.

@prolic prolic merged commit 8f304cd into prooph:commands Jan 24, 2017
@prolic
Copy link
Member

prolic commented Jan 24, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oqq @coveralls @prolic