Remove GOTO and prevent deadlock.

[bweston92]

Different syntax to remove GOTO and also made sure a release always happens after a lock to prevent deadlock.

[oqq]

puh.. i dont like this huge try/catch block around all code.
Maybe an event listener with a cleanup task would be a better solution?

see http://symfony.com/doc/current/components/console/events.html

[coveralls]

Coverage decreased (-1.06%) to 33.533% when pulling de8bc47 on bweston92:commands into c63f123 on prooph:commands.

[oqq]

I have found this symphony doc:
http://symfony.com/doc/master/console/lockable_trait.html

if not released explicitly, Symfony releases the lock
automatically when the execution of the command ends

So my suggestion is to remove all release() requests and let symphony do it automatically. If it is not working, we should create an symphony issue. ;)

Never mind .. symphony code say this is a lie

[bweston92]

Closing as this would be very hard to come across and again would be done to users implementation.

If a user ran a web server with ReactHTTP (doesn't end process so flock doesn't free).
The server had an endpoint to add services that called the command, but during the lock and release an exception is thrown then the lock would continue to be locked until the process itself dies.