add micro command for composer #31
Conversation
| '--rm', | ||
| '-i', | ||
| '--volume', | ||
| "$servicePath/$service:/app", |
There was a problem hiding this comment.
:/app has to be parsed from docker-compose.yml file
There was a problem hiding this comment.
nope .. /app is always the working directory from composer container.
| use Symfony\Component\Console\Output\OutputInterface; | ||
| use Symfony\Component\Process\ProcessBuilder; | ||
|
|
||
| final class ComposerInstallCommand extends AbstractCommand | ||
| { | ||
| const DEFAULT_TIMEOUT = 0; |
There was a problem hiding this comment.
make them private, they have no use for the outside world
|
@prolic @sandrokeil @codeliner ready for review. I will add unit tests tomorrow. |
|
@oqq well done! Question: Do we want to add a |
|
The service selection is also mandatory for install and update. But if it is not provided as argument, you have to choose from a list or the --all option is set. So it seems there is not difference for a require command and could be done in the same way. 👍 |
oqq
changed the title
|
Could be merged and moved to micro-cli for now. |
|
thx @oqq I'll check this again tomorrow and will take the required actions. |
This PR provides two new commands for composer install and composer update all php services and will resolve #21.
TODO
dockerexecutable on default paths and request path if notoptimize composer command and provide option to add parametersTo add undefined options it is necessary to provide a service name. Maybe no more composer parameters are required. However they could defined for command if needed.
configure cache and cert paths for composerComposers cache directory is shared by default on my machine. Maybe someone other using not macOS should investigate in that. Also I am not able to share my ssh sock with docker containers.