Snapshotter #9
Merged
Snapshotter #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeliner
approved these changes
Jan 21, 2017
| return []; | ||
| } | ||
|
|
||
| return $aggregate->aggregateRoot(); |
There was a problem hiding this comment.
@prolic Do you think we can rename Aggregate::aggregateRoot() to Aggregate::state()?
There was a problem hiding this comment.
The snapshot-store is also used in the event-sourcing lib. I could not come up with a name that fits both perfectly.
|
My question is not related to this PR so I'm merging it. |
basz
reviewed
Jan 21, 2017
|
Where? Can you submit a pr?
Am 21.01.2017 23:02 schrieb "Bas Kamer" <notifications@github.com>:
… ***@***.**** commented on this pull request.
i see many inline fqcn's. (not imported) but am guessing that's on purpose.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAYEvEXa7lgjyGt14GITeYvuwsggpMl-ks5rUh4PgaJpZM4LqDfT>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.