Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Query improvements #37

Merged
merged 1 commit into from Jan 11, 2017

Conversation

oqq
Copy link
Member

@oqq oqq commented Jan 11, 2017

This PR provides changes on queries for hasStream requests on MySQL and Postgres.

On MySQL, this query could be done only with index file and without fetching real data from db-table.
Since the stream_name is not relevant there is no need to fetch it, which results in a performance improvement.

Not sure about Postgres, but should be the same how on MySQL.

Note that fetchColumn for MySQL would return a string, but an integer on Postgres.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0008%) to 99.216% when pulling d78f4ab on oqq:improvements/sql_queries into 2d57e0c on prooph:projections_update.

@prolic prolic merged commit ecfe147 into prooph:projections_update Jan 11, 2017
@oqq oqq deleted the improvements/sql_queries branch January 18, 2017 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants