Merge pull request #25 from funct/quoted_tables

Quote table names in shapshot store queries
prooph · May 16, 2018 · a1faa31 · a1faa31
2 parents d1d840a + 4b93c1f
commit a1faa31
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/PdoSnapshotStore.php b/src/PdoSnapshotStore.php
@@ -49,6 +49,11 @@ final class PdoSnapshotStore implements SnapshotStore
      */
     private $disableTransactionHandling;
 
+    /**
+     * @var string
+     */
+    private $vendor;
+
     public function __construct(
         PDO $connection,
         array $snapshotTableMap = [],
@@ -61,6 +66,7 @@ public function __construct(
         $this->defaultSnapshotTableName = $defaultSnapshotTableName;
         $this->serializer = $serializer ?: new CallbackSerializer(null, null);
         $this->disableTransactionHandling = $disableTransactionHandling;
+        $this->vendor = $this->connection->getAttribute(PDO::ATTR_DRIVER_NAME);
     }
 
     public function get(string $aggregateType, string $aggregateId): ?Snapshot
@@ -207,7 +213,12 @@ private function getTableName(string $aggregateType): string
             $tableName = $this->defaultSnapshotTableName;
         }
 
-        return $tableName;
+        switch ($this->vendor) {
+            case 'pgsql':
+                return '"'.$tableName.'"';
+            default:
+                return "`$tableName`";
+        }
     }
 
     /**

diff --git a/tests/PdoSnapshotStoreTest.php b/tests/PdoSnapshotStoreTest.php
@@ -109,6 +109,7 @@ public function it_saves_multiple_snapshots_and_removes_them()
     public function it_returns_early_when_no_snapshots_given()
     {
         $pdo = $this->prophesize(PDO::class);
+        $pdo->getAttribute(PDO::ATTR_DRIVER_NAME)->willReturn('pgsql'); // Driver does not matter for this test
         $pdo->beginTransaction()->shouldNotBeCalled();
 
         $snapshotStore = new PdoSnapshotStore($pdo->reveal());