Update message producer to support PSB v4 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
codeliner
commented
Aug 30, 2015
codeliner
commented
- Package + classes are renamed to *message producer
- Classes are adjusted to use new prooph/common message handling
- Coveralls added
- Dependencies updated
- php-cs-fixer added
|
ping @prolic |
- Package + classes are renamed to *message producer - Classes are adjusted to use new prooph/common message handling - Coveralls added - Dependencies updated - php-cs-fixer added
codeliner
force-pushed
the
psb_4_support
branch
from
c745ae8
to
88ae868
Compare
| @@ -54,12 +54,14 @@ public function map(Envelope $envelope) | |||
| { | |||
| $message = $envelope->getMessage(); | |||
|
|
|||
| if (! $message instanceof BernardMessage) throw new \InvalidArgumentException(sprintf( | |||
| if (! $message instanceof BernardMessage) { | |||
| throw new \InvalidArgumentException(sprintf( | |||
There was a problem hiding this comment.
Let's use custom exceptions (Prooph\ServiceBus\Message\Bernard\Exception\InvalidArgumentException).
|
@prolic the producer lib now throws |
| */ | ||
| public function useQueue($name) | ||
| { | ||
| if (! is_string($name)) { |
There was a problem hiding this comment.
Assert minLength, or does bernard allow empty strings as queue name?
|
@prolic Assertion for non empty queue name is added + 100% test coverage 😄 |
prolic
added a commit
that referenced
this pull request
Sep 1, 2015
Update message producer to support PSB v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.