Fixing the test suite #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 242
💛 - Coveralls |
gquemener
force-pushed
the
test-suite-fix
branch
from
f77efe6
to
1a30f25
Compare
|
Here you go! All green and ready to merge 👍 🎃 |
codeliner
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a Symfony bug, the testsuite is broken on the latest Symfony release (4.3.5).
The current test suite also misses a bunch of service definitions and this is a problem since Symfony 4.2.0 (I am still not sure why, seems like the services were auto registered before that?).
This PR fixes all of that + some CS violations.
The testsuite will magically pass once Symfony 4.3.6 is released.
We can wait to merge 'till then, if you prefer :)
However, it's possible to test it locally by running
composer require symfony/dependency-injection:4.3.x-dev@devprior to runningphpunit.