Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractBusFactory attachPlugins uses hardcoded vendor name iso using vendorName() #102

Closed
DannyvdSluijs opened this issue Dec 18, 2015 · 1 comment
Closed

AbstractBusFactory attachPlugins uses hardcoded vendor name iso using vendorName() #102

DannyvdSluijs opened this issue Dec 18, 2015 · 1 comment

Comments

@DannyvdSluijs
Copy link
Contributor

At https://github.com/prooph/service-bus/blob/master/src/Container/AbstractBusFactory.php#L128 a hard coded vendor name is used in stead of the function vendorName().

When implementing the abstract bus factory and overloading vendorName() the exception would be incorrect.
@sandrokeil
Copy link
Member

@DannyvdSluijs You're right. Do you want to make a pull request please?

DannyvdSluijs added a commit to DannyvdSluijs/service-bus that referenced this issue Dec 18, 2015
@DannyvdSluijs
Merge pull request #1 from DannyvdSluijs/DannyvdSluijs-patch-#102
edd3c7b 
Dannyvd sluijs patch prooph#102
codeliner added a commit that referenced this issue Dec 18, 2015
@codeliner
Merge pull request #103 from DannyvdSluijs/develop
0574aa9 
Fixes #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DannyvdSluijs @sandrokeil