Provide container-aware factories #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ], | ||
| ] | ||
| ] | ||
| ]; |
There was a problem hiding this comment.
arrrgh, I checked the template, but this f** space is added by PHPStrom. In my defense I have to say that the PR is not ready yet ;). I'll fix it with my next commit. I think I have to investigate some time to set up php-cs-fixer ...
There was a problem hiding this comment.
There is a present for you: prooph/event-store#62
codeliner
force-pushed
the
feature/container-factories
branch
from
4a5af7d
to
cd9e4cb
Compare
codeliner
changed the title
codeliner
force-pushed
the
feature/container-factories
branch
from
cd9e4cb
to
b56b328
Compare
| ], | ||
| ], //EO service_bus | ||
| ], //EO prooph | ||
| ]; |
There was a problem hiding this comment.
Nope. Please add config dir to .php_cs file
codeliner
added a commit
that referenced
this pull request
Aug 20, 2015
Provide container-aware factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not completed yet.
Missing parts: