Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bookdown.io documentation #93

Merged
merged 1 commit into from Nov 8, 2015

Conversation

sandrokeil
Copy link
Member

I've added the bookdown.io documentation and there are some issues:

  1. Some links (license, composer.json, ...) are broken because they are not absolut
  2. It is possible to not include the bookdown templates in require-dev, but the default template looks not pretty much. I don't know if users generates the docs by yourself if we provide online docs for gh-pages and link to them in the readme.md file.
  3. I did not change the doc structure for BC but I think this is the best way

What do you think?

@sandrokeil
Copy link
Member Author

@codeliner Regarding to our conversation, we can replace the relative links for the gh-pages with an absolute uri by using sed or a bash script and point it to master. This should not be a problem.

  1. resolved
  2. resolved
  3. resolved

Ready to merge. ;-)

@codeliner codeliner changed the title [WIP] added bookdown.io documentation added bookdown.io documentation Nov 8, 2015
codeliner added a commit that referenced this pull request Nov 8, 2015
added bookdown.io documentation
@codeliner codeliner merged commit 285b0b5 into prooph:develop Nov 8, 2015
@codeliner codeliner added this to the 5.0 Release milestone Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants