Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue commands and pass pending commands to exception #97

Merged
merged 2 commits into from Nov 21, 2015

Conversation

codeliner
Copy link
Member

No description provided.

@codeliner codeliner added this to the 5.0 Release milestone Nov 21, 2015
@codeliner
Copy link
Member Author

ping @prolic

@prolic
Copy link
Member

prolic commented Nov 21, 2015

php cs issues

@codeliner
Copy link
Member Author

damn, always the same, sorry :)

prolic added a commit that referenced this pull request Nov 21, 2015
Queue commands and pass pending commands to exception
@prolic prolic merged commit e458fd7 into prooph:develop Nov 21, 2015
@sstok
Copy link

sstok commented Nov 22, 2015

You may want to enable https://styleci.io/ ;)

And there is a Gush command to update your pull-request.
https://github.com/gushphp/gush/blob/master/src/Command/Util/StyleCIPatchCommand.php

Simple configure Gush and run gush.phar pull-request:styleci 97 (only updates the remote branch but not the locale branch (yet) so make sure to pull-in the remote changes).

@codeliner
Copy link
Member Author

@sstok yeah, that is an idea or just a phpstorm file watcher ;)

I'll definitely try gush branch:changelog. We have so many packages at prooph and it is really a time consuming task to prepare releases. Today or tomorrow new major versions for a couple of components will be released. I'm curious if gush can help me speeding up the process.

@sstok
Copy link

sstok commented Nov 22, 2015

Oh thanks for the tip 👍

If gush branch:changelog doesn't work as you would like it to please open an issue so we can improve it 😃

@sstok
Copy link

sstok commented Jan 28, 2017

FYi, I'm no longer involved in Gush but I did create something else.
https://github.com/park-manager/hubkit

You can use the changelog command create a fully categorized changelog, but there is a minor catch. You must use the merge command to merge your pull-requests so that the category (and special labels like "Deprecation removal") are stored within the merge commit.

I'm using it on a daily basis now, and the only thing missing is documentation. But if you have any questions feel free the ask 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants