Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doctrine snapshot adapter to use save and overwrite #11

Merged
merged 2 commits into from Nov 2, 2015

Conversation

prolic
Copy link
Member

@prolic prolic commented Nov 2, 2015

No description provided.

@prolic prolic added this to the 1.0 Release milestone Nov 2, 2015
@@ -109,6 +109,13 @@ public function add(Snapshot $snapshot)
'blob',
]
);

$this->connection->executeQuery(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the query builder also for delete queries as table and column quoting can be different for the various database vendors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, after meal :)

codeliner added a commit that referenced this pull request Nov 2, 2015
update doctrine snapshot adapter to use save and overwrite
@codeliner codeliner merged commit 8a02327 into prooph:master Nov 2, 2015
@prolic prolic deleted the save_overwrites branch November 2, 2015 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants