Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better interop-config factory #9

Merged
merged 2 commits into from Oct 21, 2015
Merged

better interop-config factory #9

merged 2 commits into from Oct 21, 2015

Conversation

prolic
Copy link
Member

@prolic prolic commented Oct 21, 2015

No description provided.

@codeliner codeliner added this to the 1.0 Release milestone Oct 21, 2015
'snapshot_adapter' => [
'options' => [
'snapshot_grid_fs_map' => [],
'write_concern' => []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This default overrides the default write concern in the adapter. You set it here to an empty array but the adapter checks for !== null

@codeliner
Copy link
Member

@prolic see line note

@prolic
Copy link
Member Author

prolic commented Oct 21, 2015

@codeliner done

@codeliner
Copy link
Member

great

codeliner added a commit that referenced this pull request Oct 21, 2015
better interop-config factory
@codeliner codeliner merged commit 6b30735 into prooph:master Oct 21, 2015
@prolic prolic deleted the factory branch October 21, 2015 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants