Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite Snapshot Store #8

Merged
merged 4 commits into from Apr 9, 2017
Merged

Composite Snapshot Store #8

merged 4 commits into from Apr 9, 2017

Conversation

prolic
Copy link
Member

@prolic prolic commented Apr 9, 2017

  • add composite snapshot store
  • add composite snapshot store factory
  • add docs

Copy link
Member

@basz basz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, one doc comment only

## Composite Snapshot Store

This component ships with a composite snapshot store, that aggregates multiple snapshot stores. When asked to save a
snapshot or removeAll, it will call the method in all aggregated snapshot stores. If you try to get a snapshot from the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Earliest' suggests some async logic to me when is actually is prioritized.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@codeliner codeliner merged commit c0d172f into master Apr 9, 2017
@codeliner codeliner deleted the composite branch April 9, 2017 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants