Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHPStan before release 1.0.0 #109

Closed
sandrokeil opened this issue Nov 10, 2018 · 3 comments
Closed

Use PHPStan before release 1.0.0 #109

sandrokeil opened this issue Nov 10, 2018 · 3 comments

Comments

@sandrokeil
Copy link
Contributor

Maybe some issues (Comments, Types, Checks) can be fixed before release 1.0.0 with PHPStan. Can I bring a PR based on #108 ?
@codeliner
Copy link
Member

sounds good

@codeliner
Copy link
Member

but we should not focus that much on Event Machine internals for v1.0. It's just a stable release to make sure that existing projects don't break. We should focus on v2.0 without prooph/event-sourcing and prooph/service-bus.

@codeliner
Copy link
Member

Let's focus on Event Engine and use PHPStan there: https://github.com/event-engine/php-engine/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sandrokeil @codeliner