Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove GraphQL integration #84

Merged
merged 7 commits into from
Apr 15, 2018
Merged

[WIP] Remove GraphQL integration #84

merged 7 commits into from
Apr 15, 2018

Conversation

codeliner
Copy link
Member

@codeliner codeliner commented Apr 7, 2018

  • Remove GraphQL integration
  • Provide alternative GUI to inspect Schema and send messages
  • Update docs/tutorial

GraphQL support will be removed entirely.
I tried to move it to an optional package but that's too much work. If we complete the tasks above then GraphQL is not needed at all because it no longer adds a benefit

GUI is needed before we can update the docs. This PR should not be merged until tasks are completed.

/cc @camuthig

@coveralls
Copy link

Pull Request Test Coverage Report for Build 48

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-4.1%) to 60.969%

Files with Coverage Reduction New Missed Lines %
src/EventMachine.php 3 76.75%
src/JsonSchema/Type/ObjectType.php 5 74.19%
src/JsonSchema/Type/TypeRef.php 6 45.45%
src/JsonSchema/JsonSchema.php 15 57.14%
Totals Coverage Status
Change from base Build 44: -4.1%
Covered Lines: 1145
Relevant Lines: 1878

💛 - Coveralls

@codeliner codeliner merged commit 0dc8252 into master Apr 15, 2018
@codeliner codeliner deleted the rm_graphql branch April 15, 2018 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants