Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script to Python3 #19

Merged
merged 1 commit into from
Oct 6, 2022
Merged

script to Python3 #19

merged 1 commit into from
Oct 6, 2022

Conversation

arademaker
Copy link
Contributor

@arademaker arademaker commented Oct 4, 2022

This PR adapted the Python script to Python 3.x. The JSON file was pretty printed to facilitate diffs. This solves issue #16 reported by @frreiss

@sameer-pradhan this code was already in my fork for a while... I told you that before, so maybe you can accept this PR.

@arademaker
Copy link
Contributor Author

Surely on top of this PR, more changes are needed to deal with the new datasets just added in this repo. Nevertheless, I believe accepting this PR is an incremental step towards the final goal.

@skatje-myers skatje-myers merged commit b5458be into propbank:master Oct 6, 2022
@sameer-pradhan
Copy link
Member

I am currently working on making various changes to getting the data in the right shape for easy and general consumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants