refactor: use ?? + remove unnecessary typeof

propeldata · Jun 13, 2023 · b5febb9 · b5febb9
1 parent 3ba2c22
commit b5febb9
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 14 deletions.
diff --git a/packages/react/counter/src/Counter.tsx b/packages/react/counter/src/Counter.tsx
@@ -75,10 +75,10 @@ export function Counter(props: CounterProps) {
           uniqueName: query?.metric,
           counterInput: {
             timeRange: {
-              relative: query?.timeRange?.relative || null,
-              n: query?.timeRange?.n || null,
-              start: query?.timeRange?.start || null,
-              stop: query?.timeRange?.stop || null
+              relative: query?.timeRange?.relative ?? null,
+              n: query?.timeRange?.n ?? null,
+              start: query?.timeRange?.start ?? null,
+              stop: query?.timeRange?.stop ?? null
             },
             filters,
             propeller: query?.propeller
@@ -141,7 +141,7 @@ export function Counter(props: CounterProps) {
       if (!isStatic) {
         const fetchedValue = await fetchData()
 
-        if (typeof fetchedValue === 'undefined') {
+        if (fetchedValue === undefined) {
           setHasError(true)
           console.error(`QueryError: Your metric ${query?.metric} returned undefined.`)
           return

diff --git a/packages/react/counter/src/utils.ts b/packages/react/counter/src/utils.ts
@@ -29,7 +29,7 @@ export const getValueWithPrefixAndSufix = (params: {
 }) => {
   const { prefix, value, sufix, localize } = params
 
-  if (typeof value === 'undefined') return
+  if (value === undefined) return
 
   return (prefix ? prefix : '') + getValue({ value, localize }) + (sufix ? sufix : '')
 }
diff --git a/packages/react/leaderboard/src/Leaderboard.tsx b/packages/react/leaderboard/src/Leaderboard.tsx
@@ -214,10 +214,10 @@ export function Leaderboard(props: LeaderboardProps) {
             rowLimit: query?.rowLimit,
             dimensions,
             timeRange: {
-              relative: query?.timeRange?.relative || null,
-              n: query?.timeRange?.n || null,
-              start: query?.timeRange?.start || null,
-              stop: query?.timeRange?.stop || null
+              relative: query?.timeRange?.relative ?? null,
+              n: query?.timeRange?.n ?? null,
+              start: query?.timeRange?.start ?? null,
+              stop: query?.timeRange?.stop ?? null
             }
           }
         },

diff --git a/packages/react/time-series/src/TimeSeries.tsx b/packages/react/time-series/src/TimeSeries.tsx
@@ -268,10 +268,10 @@ export function TimeSeries(props: TimeSeriesProps) {
           uniqueName: query?.metric,
           timeSeriesInput: {
             timeRange: {
-              relative: query?.timeRange?.relative || null,
-              n: query?.timeRange?.n || null,
-              start: query?.timeRange?.start || null,
-              stop: query?.timeRange?.stop || null
+              relative: query?.timeRange?.relative ?? null,
+              n: query?.timeRange?.n ?? null,
+              start: query?.timeRange?.start ?? null,
+              stop: query?.timeRange?.stop ?? null
             },
             granularity,
             filters: filters,