-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-kit): add Design Tokens synchronization automation from Figma to UI Kit #165
feat(ui-kit): add Design Tokens synchronization automation from Figma to UI Kit #165
Conversation
🦋 Changeset detectedLatest commit: f808593 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
33c323c
to
270935b
Compare
cde2b16
to
42a99df
Compare
7301139
to
c4c3161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! I just added a few comments, I also think it would be nice to add tests to the scripts
I'm not 100% satisfied with the sync architecture 🤔. I have a strong feeling that it could be better. I plan to continue thinking on that during the syncing process in #206. We can also introduce the tests in that PR. |
eae7d98
to
f808593
Compare
Cool, ideally we find a way to get the |
@felipecadavid I planned to use Figma's API in the next stage because it requires a paid Enterprise plan for exporting variables:
|
Description of changes
This PR resolves:
The sync process:
Color format
torgba
in plugin's settings).variables.json
into the folder packages/ui-kit/src/themes/.yarn build
from the root folder.The sync process runs two scripts:
--propel
, and validates these variables across different theme directories to ensure consistency in design tokens.The sync went well
The sync reports missed variables
Checklist
Before merging to main: