Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts overriding custom chart config with default config #199

Conversation

sashathor
Copy link
Contributor

@sashathor sashathor commented Feb 22, 2024

Description of changes

This PR implements:

piechart-conf

  • Abstract UI components from the react examples into a new dashboard package
  • Sync the React example components with the latest updates from the UI kit

dashboard

Checklist

Before merging to main:

  • Manually tested in React apps
  • Changesets
  • Approved

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 12f0bef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@propeldata/ui-kit Patch
dashboard-example Patch
react-16 Patch
react-18 Patch
react-17 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 2:51pm

@sashathor sashathor force-pushed the sasha/pro-2771-charts-overriding-custom-chart-config-with-default-config branch from cae2a3c to 4f06242 Compare February 22, 2024 14:04
@sashathor sashathor changed the title WIP: Sasha/pro 2771 charts overriding custom chart config with default config Charts overriding custom chart config with default config Feb 23, 2024
@sashathor sashathor marked this pull request as ready for review February 23, 2024 14:37
Copy link
Contributor

@felipecadavid felipecadavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I left a few comments.

Can you also please add a test case in the components for the timeZone fix to make sure query.timeZone is the one being passed to the api?

Copy link
Contributor

@felipecadavid felipecadavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sashathor sashathor merged commit 82c19a6 into main Feb 28, 2024
3 checks passed
@sashathor sashathor deleted the sasha/pro-2771-charts-overriding-custom-chart-config-with-default-config branch February 28, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants