Fix build issues #72
Merged
Fix build issues #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jonatassales
suggested changes
Apr 26, 2023
markandrus
reviewed
Jun 13, 2023
There was a problem hiding this comment.
@felipecadavid I took a look, and had a few questions.
One thing I am thinking: using Yarn PnP here might actually be good, because it will force us to be strict with dependencies.
Comment on lines
+32
to
+33
| "@parcel/packager-ts": "^2.8.2", | ||
| "@parcel/transformer-typescript-types": "^2.8.2", |
There was a problem hiding this comment.
Why the change here? I mean, it's SemVer-compatible, but why change?
There was a problem hiding this comment.
I found an issue in parcel version 2.8.3 that was affecting the build time so I rolled it back to 2.8.2
The latest version works correctly though, so I think we can keep like this and keep the ^ for @parcel/transformer-typescript-types as well
markandrus
reviewed
Jun 13, 2023
markandrus
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes some Parcel build issues found including
yarn buildandyarn devgetting stuck.Checklist
Before merging to main:
Release notes
N/A