Fix Counter, Leaderboard and TimeSeries bugs

[felipecadavid]

This PR fixes some bugs found while testing the components in the example apps.

TimeSeries

• Connected mode re-fetched data on styles change
• Connected mode re-fetching on every re-render due to useEffect object dependencies

Leaderboard

• Connected mode re-fetched data on styles change
• Connected mode re-fetching on every re-render due to useEffect object dependencies
• Switching from variant bar to table and then to bar again made bar chart disappear

Counter

• Connected mode re-fetched data on styles change
• Connected mode re-fetching on every re-render due to useEffect object dependencies
• When Connected mode receiving a null value, it showed an error, changed to - instead
• Sometimes Counter attempted to fetch data on Static mode, added !isStatic condition to fix

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
ui-kit	⬜️ Ignored (Inspect)	Visit Preview		Jun 13, 2023 5:10pm

[jonatassales]

Looking good. I think we could improve some parts

[markandrus]

@felipecadavid +1 for the detailed PR description. Let's chat tomorrow about

1. How we document feature additions/bug fixes in this project.
   • We might want a pull request template.
   • We might start tracking a CHANGELOG.md in this project.
2. How we manually validate (with @davepropel) that a PR like this is good-to-go.

[markandrus]

@felipecadavid I am think we should probably remove the console.error for now, and plan for logging as a feature soon.

What I mean is that,

1. First of all, customers should be able to enable/disable logging; and
2. Second of all, customers may even want to provide their own callbacks to avoid sending directly to console.

Since we don't have that prepared yet, let's not add more non-configurable console.error, console.log, etc., calls to the library just yet.

Suggested change

console.error(`QueryError: Your metric ${query?.metric} returned undefined.`)

[felipecadavid]

I'm going to comment all the console.error and will leave a comment related to this

[markandrus]

@felipecadavid Why are we only calling destroyChart for variant === 'table'? What about the other variant(s)?

[felipecadavid]

We currently only have 'table' and 'bar' variants for leaderboard, what I'm doing here is stating that when the variant changes to 'table' we should then cleanup the 'bar' chart, so we allow changing the component's variant dynamically

[markandrus]

+1 — let's get this in a release candidate