Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type yAxis prop to allow logarithmic scale #82

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Add type yAxis prop to allow logarithmic scale #82

merged 5 commits into from
Jun 15, 2023

Conversation

felipecadavid
Copy link
Contributor

@felipecadavid felipecadavid commented May 18, 2023 •
edited
Loading

This PR adds a type prop to the styles api in order to allow setting the y scale type to logarithmic

@vercel
Copy link

vercel bot commented May 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui-kit ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2023 5:45pm

@acossta
Copy link
Contributor

acossta commented May 18, 2023

Looks good. But let's add it to the documentation in the Time Series readme

@felipecadavid
Copy link
Contributor Author

Looks good. But let's add it to the documentation in the Time Series readme

Done!

acossta
acossta reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@acossta acossta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions to call the prop scale vs type. It better described what it controls.

app/examples/react-18/src/components/TimeSeriesStaticTest.jsx Outdated Show resolved Hide resolved
packages/react/time-series/README.md Outdated Show resolved Hide resolved
packages/react/time-series/src/defaults.ts Outdated Show resolved Hide resolved
packages/react/time-series/src/types.ts Outdated Show resolved Hide resolved
@felipecadavid
Copy link
Contributor Author

Added suggestions to call the prop scale vs type. It better described what it controls.

Yes, makes sense, we also avoid using type which is commonly a reserved word, I'm going to refactor this

jonatassales
jonatassales suggested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@jonatassales jonatassales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I've left some suggestions

packages/react/time-series/src/types.ts Outdated Show resolved Hide resolved
packages/react/time-series/src/utils.ts Show resolved Hide resolved
markandrus
markandrus reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@markandrus markandrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, too, we should think about

  • How will we document this change to customers.
  • How will we validate this change before shipping it.

packages/react/time-series/src/utils.ts Show resolved Hide resolved
packages/react/time-series/src/utils.ts Show resolved Hide resolved
packages/react/time-series/src/utils.ts Outdated Show resolved Hide resolved
markandrus
markandrus approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@markandrus markandrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 — let's also get this in a release candidate.

@felipecadavid felipecadavid merged commit 19efbdc into main Jun 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acossta acossta acossta left review comments

@markandrus markandrus markandrus approved these changes

@jonatassales jonatassales jonatassales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felipecadavid @acossta @markandrus @jonatassales