Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new release process #85

Merged
merged 1 commit into from
Jun 15, 2023
Merged

feat: new release process #85

merged 1 commit into from
Jun 15, 2023

Conversation

markandrus
Copy link
Contributor

With this change, the next version we will publish is 0.31.0. Merging this to main should create 0.31.0-rc.0.

@felipecadavid the actual release process will be slightly different than what we discussed yesterday, but I'll catch you up on it.

$ COMMIT_RELEASE=release DRY_RUN=true PRE_RELEASE=true yarn release
➤ YN0000: ┌ Determine New Versions
➤ YN0000: │ [Dry Run] [Version Change] @propeldata/ui-kit-components: 0.2.2 -> 0.31.0-rc.0 (minor, group: @propeldata/ui-kit)
➤ YN0000: │ [Dry Run] [Version Change] @propeldata/ui-kit-graphql: 0.2.8 -> 0.31.0-rc.0 (minor, group: @propeldata/ui-kit)
➤ YN0000: │ [Dry Run] [Version Change] @propeldata/ui-kit-plugins: 0.2.1 -> 0.31.0-rc.0 (minor, group: @propeldata/ui-kit)
➤ YN0000: │ [Dry Run] [Version Change] @propeldata/react-counter: 0.26.8 -> 0.31.0-rc.0 (minor, group: @propeldata/ui-kit)
➤ YN0000: │ [Dry Run] [Version Change] @propeldata/react-leaderboard: 0.5.4 -> 0.31.0-rc.0 (minor, group: @propeldata/ui-kit)
➤ YN0000: │ [Dry Run] [Version Change] @propeldata/react-time-series: 0.30.14 -> 0.31.0-rc.0 (minor, group: @propeldata/ui-kit)
➤ YN0000: └ Completed
➤ YN0000: ┌ Determine Git Tags
➤ YN0000: └ Completed
➤ YN0000: ┌ Generating Changeset
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetching Workspace Information
➤ YN0000: └ Completed
➤ YN0000: ┌ Patching Package Manifests
➤ YN0000: └ Completed
➤ YN0000: ┌ Updating Project State
➤ YN0000: └ Completed
➤ YN0000: ┌ Updating Changelog
➤ YN0000: └ Completed
➤ YN0000: ┌ Committing Changes
➤ YN0000: │ [Dry Run] [Publish] Creating publish commit
➤ YN0000: └ Completed
➤ YN0000: ┌ Publishing Packages
➤ YN0000: │ [Dry Run] [Publish] @propeldata/ui-kit-components (next: 0.31.0-rc.0, https://registry.npmjs.com; undefined)
➤ YN0000: │ [Dry Run] [Publish] @propeldata/ui-kit-graphql (next: 0.31.0-rc.0, https://registry.npmjs.com; undefined)
➤ YN0000: │ [Dry Run] [Publish] @propeldata/ui-kit-plugins (next: 0.31.0-rc.0, https://registry.npmjs.com; undefined)
➤ YN0000: │ [Dry Run] [Publish] '@propeldata/ui-kit-components' published.
➤ YN0000: │ [Dry Run] [Publish] '@propeldata/ui-kit-plugins' published.
➤ YN0000: │ [Dry Run] [Publish] '@propeldata/ui-kit-graphql' published.
➤ YN0000: │ [Dry Run] [Publish] @propeldata/react-counter (next: 0.31.0-rc.0, https://registry.npmjs.com; undefined)
➤ YN0000: │ [Dry Run] [Publish] @propeldata/react-leaderboard (next: 0.31.0-rc.0, https://registry.npmjs.com; undefined)
➤ YN0000: │ [Dry Run] [Publish] @propeldata/react-time-series (next: 0.31.0-rc.0, https://registry.npmjs.com; undefined)
➤ YN0000: │ [Dry Run] [Publish] '@propeldata/react-counter' published.
➤ YN0000: │ [Dry Run] [Publish] '@propeldata/react-time-series' published.
➤ YN0000: │ [Dry Run] [Publish] '@propeldata/react-leaderboard' published.
➤ YN0000: └ Completed
➤ YN0000: [Dry Run] Monodeploy completed successfully
➤ YN0000: ┌ Cleaning Up
➤ YN0000: └ Completed
➤ YN0000: Done in 1s 668ms
[Dry Run] git push origin pre-release-support
[Dry Run] git push origin refs/tags/@propeldata/ui-kit@0.31.0-rc.0

@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview Jun 15, 2023 8:49am

markandrus
markandrus commented Jun 15, 2023
View reviewed changes
.github/workflows/publish-release.yml
@@ -0,0 +1,54 @@
name: publish-release

on: workflow_dispatch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows us to manually trigger the "publish-release" workflow. Now,

  • "publish-pre-release" will run on every merge to main, creating x.y.z-rc.N, x.y.z-rc.M, etc.
  • "publish-release" will be manually triggered when we are ready to release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read more about it here: https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow

app/examples/react-16/package.json
@@ -1,5 +1,6 @@
{
"name": "react-16",
"private": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never want to publish the React apps, so setting to private.

package.json
@@ -40,6 +40,7 @@
"@typescript-eslint/parser": "^5.43.0",
"babel-loader": "^8.3.0",
"commitizen": "^4.2.5",
"conventional-changelog-angular": "^6.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting an error before. This needed to be set at the top-level.

packages/core/components/package.json
@@ -11,7 +11,8 @@
"build": "parcel build"
},
"publishConfig": {
"access": "public"
"access": "public",
"group": "@propeldata/ui-kit"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All our packages will be considered part of a group named "@propeldata/ui-kit". They will all share the same version (Lerna-style). The resulting git tags will look like "@propeldata/ui-kit@x.y.z" and "@propeldata/ui-kit@x.y.z-rc.N".

packages/core/release/package.json
Comment on lines +22 to +24
"peerDependencies": {
"conventional-changelog-angular": "^6.0.0"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to a peer dependency, since it needs to be installed at the top-level.

packages/core/release/src/index.ts
@@ -8,13 +8,19 @@ import { execSync } from 'child_process'
async function main(): Promise<void> {
try {
const autoCommitMessage = process.env.COMMIT_MESSAGE
const dryRun = process.env.DRY_RUN === 'true'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed this for testing.

@markandrus markandrus merged commit 3f51002 into main Jun 15, 2023
2 checks passed
@markandrus markandrus deleted the pre-release-support branch June 15, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipecadavid felipecadavid felipecadavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markandrus @felipecadavid