New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run vs build time version #580
Run vs build time version #580
Conversation
yay, bad rebase? |
…on do not match, refs #577
soo, after some hardcore rebase action the PR should be clean |
@@ -30,7 +30,7 @@ class Propel | |||
/** | |||
* The Propel version. | |||
*/ | |||
const VERSION = '1.6.7'; | |||
const VERSION = '1.6.8-PRE'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willdurand is this a wanted modification ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required for the check to work properly, because otherwise the git version and the latest stable version could not be differentiated (dont't know if propel defines its version also in other places?)
the first commit showed that the feature works as expected and the second fixes the version constants for the unit tests to pass. the implemented check does not work when propel is initialized using the |
…when runtime.xml based tasks will be run.
ready to go. |
Thanks |
added warning when build-time propel version and runtime-propel version do not match
see #577