Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Replace the configuration part #285

Closed
willdurand opened this issue Jul 30, 2012 · 6 comments
Closed

[RFC] Replace the configuration part #285

willdurand opened this issue Jul 30, 2012 · 6 comments
Labels

Comments

@willdurand
Copy link
Contributor

... with something else.

The Generator configuration is tied to Phing, because of the file syntax (pseudo ini file). There are tons of propel. lalala everywhere, and I tend to hate that.

The Symfony2 Config component seems a good candidate to handle that part:

We have tons of build properties. It doesn't make sense to keep this naming, and the component introduced above could help us to build a strong configuration (thanks to the TreeBuilder). We can support configuration in different formats, and so on.

What do you think?

@stephpy
Copy link
Contributor

stephpy commented Jul 30, 2012

👍 I'm sure it'll be part of a lot of oss projects, and being able to have configuration on yaml, php or may be annotations is great + the benefits of maintenance :)

@fzaninotto
Copy link
Member

As most Symfony components, I think this one is overengineerd (LoaderResolver? How about a FileVoterLoaderResolverInterface?)

But it's not as if we had a choice (http://hubscovery.com/search?q=config+l%3Aphp)

So ok for me. But it's a tough job.

@rande
Copy link

rande commented Jul 30, 2012

The OptionResolver can also be used.

@hhamon
Copy link
Member

hhamon commented Nov 4, 2012

I would be +1 if we decide to support multiple configuration formats otherwise we could stay on a simple handmade solution.

@tacone
Copy link

tacone commented Nov 13, 2012

Not supporting php configuration format in 1.6 is a big entry barrier for my use case.

So please do, I think is a great idea :-)

@cristianoc72
Copy link
Member

This issue should be closed (imho).

@marcj marcj closed this as completed Jul 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants