[Security] AclProvider #100
Conversation
|
Tests will require this pull request to be merged propelorm/Propel#276 |
| * | ||
| * @return AclClass | ||
| */ | ||
| public static function fromAclObjectIdentity(ObjectIdentityInterface $objectIdentity, PropelPDO $con = null) |
|
Awesome work! |
|
@havvg Is it good to merge for you? |
|
I would like to add handling of the |
|
I got a question on the schema part. I added a I thought of a |
|
Interesting question, the command |
|
@willdurand If you are good with the last commit (the command), then it's good to merge. I moved the schema file on directory up, as the target file needs to be named "_schem.xml" and this was the easiest way with least impact. |
|
You may need to rebase this PR |
The schema is compatible with the distributed schema of the Security component.
* fix ObjectIdentityQuery::findGrandChildren
* change default inherited value to true to comply with database default value
The MutableAclProviderInterface expects to remove all child ACLs upon deletion. * fix createAcl to check for existing parent
* re-factor Tests\Model\Acl\TestCase to Tests\AclTestCase sharing between Model\Acl and Security\Acl tests * fix schema setting auditing flags to true by default * fix MutableAcl inserting field based ACEs * fix MutableAclProvider removing class based ACEs if last object identity is being removed * fix EntryQuery error message if non-object has been provided in list of SecurityIdentity
* fix (un)serialize of (Field)Entry
* fix usage of existing database entries
* update provider class to AuditableAclProvider * change auditing default to be more reasonable, 90% use case: log failures only * add transformers to Model\Acl\Entry converting from/to Security\Acl\Domain\Entry * fix MutableAclProvider to use getAcl method instead of creating MutableAcl directly * re-factor MutableAcl::updateAce and MutableAclProvider::persistAcl to use Entry transformers
* move acl_schema.xml into Resources to avoid being retrieved by default * re-factor parent tasks methods to use separated methods for re-usage
|
Rebased onto master. |
|
@willdurand Good to go. |
|
Can you write some documentation on propelorm.github.com ? |
|
Many many many thanks @havvg !!! |
|
No promises on the "when", but I will add some docs for propelorm.github.com. Basic docs are in the README so far. |
|
I've added a very first draft: http://www.propelorm.org/cookbook/symfony2/the-symfony2-security-component-and-propel.html#acl_implementation (just got text fom the README). |
Add an implementation for ACL of the Security component.