Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce error message if bundle argument is set #386

Merged
merged 1 commit into from Jan 23, 2016
Merged

Conversation

havvg
Copy link
Member

@havvg havvg commented Jan 23, 2016

This fixes #180.

The kernel will throw an exception if the bundle could not be found, which also contains the name of the bundle.

This fixes propelorm#180.

The kernel will throw an exception if the bundle could not be found, which also contains the name of the bundle.
havvg added a commit that referenced this pull request Jan 23, 2016
enforce error message if bundle argument is set
@havvg havvg merged commit b02a4fe into propelorm:1.5 Jan 23, 2016
@c33s
Copy link

c33s commented Jan 26, 2016

#180 (comment)

don't think it really fix the issue you closed. for DX you should really add a helpful exception

 if ($this->bundle == null)
 {
     /*
        something like abort the command and print a helpful message
        - invalid bundlename
        - have you prefixed it with @?
        - do you use powershell? -> quote the command

     */
 }

@havvg
Copy link
Member Author

havvg commented Jan 26, 2016

I tried it, you will receive the error message from the kernel about registering the bundle etc. This should do the trick?

I mean, we can't explicitly hint on any shells the user may use and how he is supposed to interact with it. If your shell requires escaping an @-sign, then so be it, another shell requires escaping other characters, imho that's out of scope.

The @-problem for example will be there for any command he uses within the Symfony eco-system, that utilises the logical names - and actually, the @ isn't required at all, it will be cut off anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants