Test with rebar3 #234
Merged
Test with rebar3 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: Let's see how many warnings this is generating...
PR proper-testing#184, along with various improvements and very good tests, also introduced a test that does not make much sense: containing a ?SUCHTHAT as the third argument of a ?LET macro. This commit removes that test. See also the comment and discussion at: proper-testing@6540152#commitcomment-35664733
and Thanks for All the Fish
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 83.05% 83.02% -0.04%
==========================================
Files 13 13
Lines 3169 3169
==========================================
- Hits 2632 2631 -1
- Misses 537 538 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PropEr has been running its test suite with a home-brewed patched version of
rebarfor very a long time now, because its test suite was full of compiler warnings when compiled with the official rebar and/or withrebar3.This PR finally(!) cleans up the PropEr test suite from all the warnings and removes the patched version of
rebarfrom the repository. From now on, tests are run withrebar3.