Use more variables for robot tests.

propertyshelf · Mar 8, 2015 · 465f963 · 465f963
1 parent b744add
commit 465f963
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 14 deletions.
diff --git a/src/ps/plone/mls/tests/robot/selectors/default.robot b/src/ps/plone/mls/tests/robot/selectors/default.robot
@@ -3,4 +3,10 @@
 # Default variables used for testing. Customized variables might
 # exist for specific Plone versions.
 
+${LINK_DEVELOPMENT_COLLECTION_ACTIVATE}  css=#plone-contentmenu-actions-development-collection-activate
+${LINK_DEVELOPMENT_COLLECTION_DEACTIVATE}  css=#plone-contentmenu-actions-development-collection-deactivate
 ${LINK_DEVELOPMENT_CONFIGURATION_TAB_FITER}  css=div.pb-ajax #fieldsetlegend-filter
+
+${LINK_LISTING_COLLECTION_ACTIVATE}  css=#plone-contentmenu-actions-listing-collection-activate
+${LINK_LISTING_COLLECTION_DEACTIVATE}  css=#plone-contentmenu-actions-listing-collection-deactivate
+
diff --git a/src/ps/plone/mls/tests/robot/selectors/plone-4.x.robot b/src/ps/plone/mls/tests/robot/selectors/plone-4.x.robot
@@ -2,5 +2,3 @@
 
 # Variables specific for Plone 4.x.
 # See default.robot for all available variables.
-
-${LINK_DEVELOPMENT_CONFIGURATION_TAB_FITER}  css=div.pb-ajax #fieldsetlegend-0
diff --git a/src/ps/plone/mls/tests/robot/test_developments.robot b/src/ps/plone/mls/tests/robot/test_developments.robot
@@ -22,10 +22,10 @@ Show how to activate the development collection
     Wait until element is visible
     ...  css=#plone-contentmenu-actions dd.actionMenuContent
 
-    ${note1}  Add pointy note  css=#plone-contentmenu-actions-development-collection-activate
+    ${note1}  Add pointy note  ${LINK_DEVELOPMENT_COLLECTION_ACTIVATE}
     ...  Click to activate the Development Collection
     ...  position=left
-    Mouse over  css=#plone-contentmenu-actions-development-collection-activate
+    Mouse over  ${LINK_DEVELOPMENT_COLLECTION_ACTIVATE}
     Update element style  portal-footer  display  none
 
     Capture and crop page screenshot
@@ -36,7 +36,7 @@ Show how to activate the development collection
     Remove elements  ${note1}
 
     ${href} =  get element attribute
-    ...  css=#plone-contentmenu-actions-development-collection-activate@href
+    ...  ${LINK_DEVELOPMENT_COLLECTION_ACTIVATE}@href
     go to  ${href}
 
     Capture and crop page screenshot
@@ -65,10 +65,10 @@ Show how to activate the development collection
     Wait until element is visible
     ...  css=#plone-contentmenu-actions dd.actionMenuContent
 
-    ${note1}  Add pointy note  css=#plone-contentmenu-actions-development-collection-deactivate
+    ${note1}  Add pointy note  ${LINK_DEVELOPMENT_COLLECTION_DEACTIVATE}
     ...  Click to deactivate the Development Collection
     ...  position=left
-    Mouse over  css=#plone-contentmenu-actions-development-collection-deactivate
+    Mouse over  ${LINK_DEVELOPMENT_COLLECTION_DEACTIVATE}
     Update element style  portal-footer  display  none
 
     Capture and crop page screenshot
@@ -79,7 +79,7 @@ Show how to activate the development collection
     Remove elements  ${note1}
 
     ${href} =  get element attribute
-    ...  css=#plone-contentmenu-actions-development-collection-deactivate@href
+    ...  ${LINK_DEVELOPMENT_COLLECTION_DEACTIVATE}@href
     go to  ${href}
 
     Capture and crop page screenshot

diff --git a/src/ps/plone/mls/tests/robot/test_listings.robot b/src/ps/plone/mls/tests/robot/test_listings.robot
@@ -22,10 +22,10 @@ Show how to activate the listing collection
     Wait until element is visible
     ...  css=#plone-contentmenu-actions dd.actionMenuContent
 
-    ${note1}  Add pointy note  css=#plone-contentmenu-actions-listing-collection-activate
+    ${note1}  Add pointy note  ${LINK_LISTING_COLLECTION_ACTIVATE}
     ...  Click to activate the Listing Collection
     ...  position=left
-    Mouse over  css=#plone-contentmenu-actions-listing-collection-activate
+    Mouse over  ${LINK_LISTING_COLLECTION_ACTIVATE}
     Update element style  portal-footer  display  none
 
     Capture and crop page screenshot
@@ -36,7 +36,7 @@ Show how to activate the listing collection
     Remove elements  ${note1}
 
     ${href} =  get element attribute
-    ...  css=#plone-contentmenu-actions-listing-collection-activate@href
+    ...  ${LINK_LISTING_COLLECTION_ACTIVATE}@href
     go to  ${href}
 
     Capture and crop page screenshot
@@ -59,10 +59,10 @@ Show how to activate the listing collection
     Wait until element is visible
     ...  css=#plone-contentmenu-actions dd.actionMenuContent
 
-    ${note1}  Add pointy note  css=#plone-contentmenu-actions-listing-collection-deactivate
+    ${note1}  Add pointy note  ${LINK_LISTING_COLLECTION_DEACTIVATE}
     ...  Click to deactivate the Listing Collection
     ...  position=left
-    Mouse over  css=#plone-contentmenu-actions-listing-collection-deactivate
+    Mouse over  ${LINK_LISTING_COLLECTION_DEACTIVATE}
     Update element style  portal-footer  display  none
 
     Capture and crop page screenshot
@@ -73,7 +73,7 @@ Show how to activate the listing collection
     Remove elements  ${note1}
 
     ${href} =  get element attribute
-    ...  css=#plone-contentmenu-actions-listing-collection-deactivate@href
+    ...  ${LINK_LISTING_COLLECTION_DEACTIVATE}@href
     go to  ${href}
 
     Capture and crop page screenshot