Add no_std + alloc support, refactoring persistence #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZackPierce
force-pushed
the
no_std_support
branch
from
e6ff370
to
49b9069
Compare
AltSysrq
reviewed
Apr 28, 2018
| use std::collections::{BTreeMap, BTreeSet}; | ||
|
|
||
| /// Failure persistence option that loads and saves seeds in memory | ||
| /// on the heap. |
There was a problem hiding this comment.
Could you expand in the docs on how this would be useful?
There was a problem hiding this comment.
Sure thing! Updated in an additional commit.
|
Some additional fixes had to be made to account for changes in |
|
@AltSysrq Ping for prospective approval/merge/version-bump/glory. |
|
Sorry for the delay. Latest changes look good, so I'll see about getting this out now. |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to #47
Three related kinds of changes were necessary:
FailurePersistence, of whichFileFailurePersistence(the legacy enum of file-lookup-related-variants) is one available option.I'm not a fan of the verbosity necessary to manage all the conditional uses, but I didn't see any non-magical alternative.
A few nonessential changes may have snuck in due to auto-rustfmt'ing. If any are problematic, I'd be happy to roll them back.
CC: @AltSysrq