-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_std + alloc support, refactoring persistence #48
Conversation
e6ff370
to
49b9069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question, but other than that this looks great! Thanks for taking the time to make this contribution.
use std::collections::{BTreeMap, BTreeSet}; | ||
|
||
/// Failure persistence option that loads and saves seeds in memory | ||
/// on the heap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you expand in the docs on how this would be useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing! Updated in an additional commit.
Some additional fixes had to be made to account for changes in |
@AltSysrq Ping for prospective approval/merge/version-bump/glory. |
Sorry for the delay. Latest changes look good, so I'll see about getting this out now. |
Awesome, thank you! |
Pursuant to #47
Three related kinds of changes were necessary:
FailurePersistence
, of whichFileFailurePersistence
(the legacy enum of file-lookup-related-variants) is one available option.I'm not a fan of the verbosity necessary to manage all the conditional uses, but I didn't see any non-magical alternative.
A few nonessential changes may have snuck in due to auto-rustfmt'ing. If any are problematic, I'd be happy to roll them back.
CC: @AltSysrq