-
Notifications
You must be signed in to change notification settings - Fork 4
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last_vote attribute in Bills JSON endpoint? #177
Comments
@mininternet: Individual bill responses have a |
@dwillis - Would this be the case for every Bill endpoint, i.e. bills by legislator, bills by subject/search, etc? Checking for a zero length votes array would work well, but i know there are occasional differences in field structures between endpoints, so not sure if Votes are present everywhere. |
@mininternet currently it's only on the Specific Bill endpoint, so no. Sounds like a |
@dwillis - With Sunlight it was a last_vote date value, which provided more info than just a boolean. But if this is problematic, a boolean would work well too. |
@mininternet it's not problematic. We'll add it to bill responses. |
Excellent, thanks! |
@mininternet We've added |
@dwillis - Great news, thanks! I've had a couple of fires to put out, so haven't yet implemented, but will do so by this weekend. Feel free to close this comment. |
Previously with Sunlight there was a last_vote attribute, which was very useful for determining whether to show a Votes button in the UI.
Without a flag now the Votes button will always be displayed, which isn't useful since most bills haven't been voted on, which makes the UI misleading.
Not sure what better way to know when to offer a Votes option, per Bill.
The text was updated successfully, but these errors were encountered: