-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive function causing a stack overflow #23
Comments
Makes total sense and at first glance I think your solution will work. Can On Tue, Nov 5, 2013 at 6:34 PM, Eric Sagara notifications@github.comwrote:
|
Yo Eric, did your PR close this issue? |
I think so, there was an issue somewhere in that where it would get caught Eric On Wed, Dec 18, 2013 at 3:54 PM, Jeremy B. Merrill <notifications@github.com
|
Is it possible that the below line is not evaluating to true? I can see https://github.com/propublica/upton/blob/master/lib/upton.rb#L223 Eric On Wed, Dec 18, 2013 at 9:49 PM, Eric Sagara esagara@gmail.com wrote:
|
I'm not sure exactly what's happening, but I noted it in #28. Will look into it greater depth shortly. I'll write a test too :) |
https://github.com/propublica/upton/blob/master/lib/upton.rb#L314-L326
Will cause a stack overflow with large paginations >2300 or so. Possible solution:
The text was updated successfully, but these errors were encountered: