Unauthenticated/unauthorized pull request broken

[edrex]

I added an "edit this page" link to my Jekyll site. Clicking as an anonymous (not signed in to github) or unauthorized (but signed in) user results in the below:

Failed to load resource: the server responded with a status of 404 (Not Found) https://api.github.com/repos/edrex/edrex.github.io/forks
Uncaught SyntaxError: Unexpected token u prose.min.js:18
Uncaught TypeError: Cannot set property 'disabled' of undefined prose.min.js:22

[edrex]

Rather, editing and then clicking "Submit change request" results in the listed output

[mikemorris]

Ah, forgot to add a condition for unauthorized/anonymous users, thanks for catching this!

[mikemorris]

I'm pretty sure that the Pull Request API needs to create the request from an existing branch/ref, which I believe would require authentication to create a personal fork. Do you see this flow simply prompting a user to login to submit a pull request?

http://developer.github.com/v3/pulls/#create-a-pull-request

[edrex]

That seems right (direct unauthed user through oauth flow). Was this feature working at some point? I assumed it was and there was a regression, but maybe it's not fully formed yet?

[mikemorris]

@edrex I'll have to check if this was handled in the legacy branch, it may have been implemented before the refactor to Backbone models and away from github.js (although it doesn't appear that GitHub's API supports unauthenticated pull requests). It has not been implemented in the refactor yet.

[mikemorris]

Tracking in #584

[iamstarkov]

I think this issue is still open, because I can reproduce it on my site:

1. go to http://frontender.info/building-3d-in-the-browser-with-three-js/
2. click «можете отредактировать статью», which open http://prose.io/#FrontenderMagazine/building-3d-in-the-browser-with-three-js/edit/master/rus.md
3. I added an title and tryed to save the file, after that infinite loop happens and there this errors in console:
   

[iamstarkov]

polite ping

[iamstarkov]

are interested in closing this issue?

[fulldecent]

Hello and thank you for this issue report. There have been several point releases in Prose since this issue was opened and there has not been much discussion here. I wanted to ask if you could please assist in confirming this is still an issue in the latest version of the product. If it is fixed, please close this issue :-)

Also, if possible could you please

• Find out if this only affects certain browsers
• Create a test case -- a list of steps we can perform to reproduce the problem
• Enable web developer extensions and report the Javascript error message. And when in doubt, be over-descriptive of the bug and how you discovered it.

Since this project is looking for new maintainers (#743), it will be helpful if users can double check the old issues and delete ones that are fixed. This will be super helpful for the new team that works on moving this project forward.

I'm sorry this message is impersonal. And thanks for your help!

[phillipadsmith]

Closing this issue, as it is being tracked and discussed more actively in #643.