Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

Bank search not working when using two words split by space #279

Closed
bzagozda opened this issue Feb 20, 2020 · 2 comments · Fixed by #357
Closed

Bank search not working when using two words split by space #279

bzagozda opened this issue Feb 20, 2020 · 2 comments · Fixed by #357
Assignees
Labels
bug Something isn't working

Comments

@bzagozda
Copy link

Hi,

when using for example new FpBanks(..).search(new BanksCriteria().withSearch("Sparkasse Heid"))
I don't get any results, even though when using finapi https://sandbox.finapi.io/api/v1/banks directly for given search string i get 4 results.
The thing is that url builder replaces whitespace with %2B instead %20 which doesn't work with finapi.

bzagozda added a commit to bzagozda/finapi-java-client that referenced this issue Feb 25, 2020
bzagozda added a commit to bzagozda/finapi-java-client that referenced this issue Feb 25, 2020
@ccostin93 ccostin93 assigned ccostin93 and bzagozda and unassigned ccostin93 Mar 5, 2020
@proshin-roman
Copy link
Owner

The bug should be fixed as it's explained here: #280 (comment)

ccostin93 added a commit that referenced this issue Nov 21, 2020
ccostin93 added a commit that referenced this issue Nov 21, 2020
ccostin93 added a commit that referenced this issue Nov 21, 2020
ccostin93 added a commit that referenced this issue Nov 21, 2020
ccostin93 added a commit that referenced this issue Nov 21, 2020
ccostin93 added a commit that referenced this issue Nov 21, 2020
# Conflicts:
#	src/main/java/org/proshin/finapi/transaction/in/DeleteTransactionsCriteria.java
ccostin93 added a commit that referenced this issue Nov 21, 2020
@ccostin93 ccostin93 linked a pull request Nov 21, 2020 that will close this issue
@ccostin93 ccostin93 added the bug Something isn't working label Nov 21, 2020
@ptrepkaVL
Copy link

When do you plan to push those changes to maven repo?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants