Use langchain for pinecone #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ristomcgehee! Will review shortly, but there is a CI update we need to make this week to enable testing from forked repos. Just wanted to comment so it's clear this isn't stale or forgotten |
cherbel
requested changes
Oct 2, 2023
seanpmorgan
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
LGTM as well. Thanks so much @ristomcgehee this is a great step toward where we're headed with rebuff. Per your original PR comment, feel free to move forward on #16 -- specifically using Chroma.
Since you've abstracted the vector stores to use langchain we can easily mirror your changes in #52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm interested in helping out with this project so I found an issue that I thought I could tackle. In this PR, I'm abstracting the use of Pinecone by using
VectorStorefromlangchain. This is a necessary step before being able to use Chroma or Supabase as a vector store. If this PR looks good, I can work on the rest of #16.Part of #16