Update Packaging #65
Merged
Update Packaging #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cherbel
commented
Oct 24, 2023
•
cherbel
commented
- Updates to Javascript SDK for packaging (Now published on NPM)
- Removes old app directory (no longer used)
- Refactors Server
- Refactors server to use new rebuff NPM package
- General cleanup and consolidation of all dependencies into the server directory
- Updates server install steps in readme
- Removes mono-repo package files and artifacts that are no longer needed.
cherbel
added
documentation
seanpmorgan
requested changes
Oct 25, 2023
Comment on lines
-16
to
-19
|
|
||
| init: init-python-sdk init-server | ||
| npm install | ||
|
|
There was a problem hiding this comment.
So this is called in our github workflow:
https://github.com/protectai/rebuff/blob/main/.github/workflows/python_tests.yaml#L27-L28
https://github.com/protectai/rebuff/blob/main/python-sdk/tests/conftest.py#L21-L58
Which stands up the server for python-sdk tests (and subsequently tests ingration with the server -- now pinned to a specific release). Ultimately we should replace this setup with unit testing individual TS functions but for the time being is there a need to remove this?
There was a problem hiding this comment.
Added it back, although I removed the npm install, because the init-server step runs the install in the server directory, and there is no longer a package.json in the root directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.