fix(GlyphsGeometry): move prototype fallback to class

protectwise · Nov 15, 2022 · b55a0c8 · b55a0c8
1 parent fc4e549
commit b55a0c8
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/packages/troika-three-text/src/GlyphsGeometry.js b/packages/troika-three-text/src/GlyphsGeometry.js
@@ -95,6 +95,14 @@ class GlyphsGeometry extends InstancedBufferGeometry {
     this.boundingBox = new Box3()
   }
 
+  // Compat for pre r109:
+  setAttribute(name, attribute) {
+    if (super.setAttribute) return super.setAttribute(name, attribute)
+
+    this.attributes[ name ] = attribute
+    return this
+  }
+
   computeBoundingSphere () {
     // No-op; we'll sync the boundingSphere proactively when needed.
   }
@@ -217,14 +225,6 @@ class GlyphsGeometry extends InstancedBufferGeometry {
   }
 }
 
-// Compat for pre r109:
-if (!GlyphsGeometry.prototype.setAttribute) {
-  GlyphsGeometry.prototype.setAttribute = function(name, attribute) {
-    this.attributes[ name ] = attribute
-    return this
-  }
-}
-
 
 function updateBufferAttr(geom, attrName, newArray, itemSize) {
   const attr = geom.getAttribute(attrName)